fix warning and improve encrypt #60
Conversation
There was a problem hiding this comment.
As mentioned in #55 (comment), I have a bit of investigation to do on how long the -iter option has been available before I'd be comfortable in making this change. It would definitely be a backward incompatible thing, so I also need to understand the migration workflow for existing users. I'll circle back to this change though, and appreciate you taking the time to open up this PR.
| @@ -0,0 +1,3 @@ | |||
| .idea/** | |||
|
|
|||
| transcrypt.iml | |||
There was a problem hiding this comment.
These types of ignore patterns that aren't really project-specific should more naturally fall under your global user ~/.gitignore file:
git config --global core.excludesfile '~/.gitignore'
There was a problem hiding this comment.
thanks for taking your time,this project was really simple and great,I will remember to exclude the project-specific file
| @@ -292,8 +292,8 @@ save_helper_scripts() { | |||
| else | |||
| cipher=$(git config --get --local transcrypt.cipher) | |||
| password=$(git config --get --local transcrypt.password) | |||
| salt=$(openssl dgst -hmac "${filename}:${password}" -sha256 "$filename" | tail -c 16) | |||
| ENC_PASS=$password openssl enc -$cipher -md MD5 -pass env:ENC_PASS -e -a -S "$salt" -in "$tempfile" | |||
| salt=$(openssl dgst -hmac "${filename}:${password}" -sha256 "$filename" | tail -c 17) | |||
|
backward incompatible is very import ,but '-iter' option openssl is really recommended,so I suggest that in new project , write transcrypt version to git,then if the transcrypt version is exist and correct ,then use new function,else use the old function. |
|
Definitely agree that we should modernize the algorithm to increase security and figure out the proper migration path, whether that means adding version checking into the script or something else...that said, it's not a decision I want to rush. |
yeah,couldn't agree more,no need to rush |
ghost
closed this
fix #56
fix #59
maybe it is not incompatible with last versions
I have simply test it, it works well