Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure sensitive data is not logged in components #152

Open
stas-fomenko opened this issue Sep 25, 2020 · 0 comments
Open

Make sure sensitive data is not logged in components #152

stas-fomenko opened this issue Sep 25, 2020 · 0 comments

Comments

@stas-fomenko
Copy link

stas-fomenko commented Sep 25, 2020

Example of what should be fixed:
https://github.com/elasticio/elasticio/blob/0a290c8636aed69904eae0987cdd278b9cd1f8e2/tools/sailor-performance-analyze/sailor-nodejs/lib/sailor.js#L72

data that is logged by sailor-nodejs in components:

Received step data: 
{
  "id": "step_1",
  "comp_id": "5f6b54b68636120011b43b9f",
  "function": "httpRequestTrigger",
  "config": {
    "secretId": "5f6c7d69276f4800116ededd",
    "reader": {
      "auth": {
        "basic": {
          "password": "",
          "username": ""
        }
      },
      "body": {
        "contentType": "multipart/form-data",
        "urlencoded": [],
        "formData": [],
        "raw": ""
      },
      "headers": [],
      "url": "\"https://via.placeholder.com/150\"",
      "method": "GET"
    }
  },
  "is_passthrough": true,
  "variables": {}
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant