Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable naming of database columns #14

Open
elcorto opened this issue Nov 19, 2023 · 1 comment
Open

Configurable naming of database columns #14

elcorto opened this issue Nov 19, 2023 · 1 comment
Assignees

Comments

@elcorto
Copy link
Owner

elcorto commented Nov 19, 2023

Add an optional prefix pset_ (such as run(..., pset_prefix="pset_")) to all pset variables such that we have a clear distinction in the db:

book keeping
  _pset_id
  _run_id
  _pset_hash
  ...

pset content
  pset_foo
  pset_bar
  ...

results added by worker() and/or eval scripts. Users can here also add
prefixes as they wish, e.g. `postproc_` or `eval_`.
  baz
  boing
  ...
@elcorto
Copy link
Owner Author

elcorto commented Mar 7, 2024

Another option is a minimal naming convention where "prefix" fields such as _pset_id are added before calling a worker, which we do now. Then, users could be encouraged to name all returned fields in worker with a "postfix" notation such as result_ (inspired by how sklearn names estimator attrs after calling fit()). Then, all fields which don't have either an underscore pre- or postfix are considered pset params and will be used in hash calculations, should we need to re-calculate the hash of a database row. Still, the refresh tooling may have an additional option to specify the included fields, as outlined in #15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant