Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): retain scroll position in details view when selecting another time (24h, 72h, 30d, 12mo, all) #7617

Open
consideRatio opened this issue Dec 25, 2024 · 0 comments
Labels
frontend 🎨 help wanted javascript Pull requests that update Javascript code

Comments

@consideRatio
Copy link
Contributor

consideRatio commented Dec 25, 2024

Is your feature request related to a problem? Please describe.

When looking at for example the net exchange chart in the details panel for a zone, and toggle from one time view to another, for example 24h to 72h, the scroll position gets reset. I think this isn't ideal, and that it would be better to retain some kind of scroll position to help users retain focus on what they are interested in.

As a practical example, I'd like to look at various charts that I need to scroll down to see, but when switching time views (24h -> 30d for example), I prefer to not need to scroll back down in between doing it.

Describe the solution you'd like

I think the scroll position should be retained and restored when loading the new time view in some way. Exactly how, I'm not sure.

Describe solution implementations you've considered

  • To always reset the scroll position (current behavior)
  • To restore the scroll position to the same relative position (may be good enough, probably easy)
  • To restore the scroll position to the content relative position (may be more complicated, but perhaps more on point?)

Additional context

Initially observed by @IngvarSundell. A sibling issue to this is #7618.

@consideRatio consideRatio changed the title feat(web): retain scroll position in details view when switching time (24h, 72h, 30d, 12mo, all) feat(web): retain scroll position in details view when selecting another time (24h, 72h, 30d, 12mo, all) Dec 25, 2024
@VIKTORVAV99 VIKTORVAV99 added help wanted frontend 🎨 javascript Pull requests that update Javascript code labels Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend 🎨 help wanted javascript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests

2 participants