Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch CV out 2 uninitialized #34

Open
beserge opened this issue Sep 28, 2021 · 2 comments
Open

Patch CV out 2 uninitialized #34

beserge opened this issue Sep 28, 2021 · 2 comments

Comments

@beserge
Copy link
Contributor

beserge commented Sep 28, 2021

pinMode(PIN_PATCH_CV_1, OUTPUT);

CV_1 is initialized twice on the patch, rather than initializing CV_1, then CV_2.

@beserge
Copy link
Contributor Author

beserge commented Sep 28, 2021

While we're at it, the gate inits a few lines above use hardcoded ints rather than the PATCH_GATE_1 defines

@senorblasto
Copy link

This is the issues section, for showing bugs.

If you think the code should be changed you can make a pull request.

The analog outputs do not even need to be declared to the lines of code do not even need to be there at all as far as I'm aware

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants