-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply patch for react-native version #1845
Comments
Hi @marc-simon - Thanks for your question. At the moment it is not possible to modify the version of react-native that is bundled in ern. That's because we use an unmodified packaged artifact (com.walmartlabs.ern:react-native), deployed to maven central. The solution in the linked issue looks reasonable though, and several other people have shown interests as well. I'd suggest this to be merge to react-native first, which will then also get picked up by ern. |
Hi @friederbluemle, thanks for the response. Although, it's an important issue to be fixed the fix/patch mentioned seems like a quick fix rather long-term fix as react-native deprecated using scaleY (and it's been more than an year) Theoretically, if I fork https://github.com/electrode-io/react-native/tree/0.64-ern, patch & publish to my own private maven repo and use that in development ern by making relevant changes in following lines
it should work right? Could you please suggest if there's anything else to take care of? |
@marc-simon - Yes, that looks like it should work 👍 |
Hi, Is there any way to apply a patch to the react-native version being bundled in ern?
I want to apply the following patch to react-native
facebook/react-native#30034 (comment)
Can you please suggest on how can i do this?
The text was updated successfully, but these errors were encountered: