electron-builder does not bundle the dependencies correctly in the build

[nikitavoloboev]

• Electron-Builder Version: 24.4.0

• Node Version: 18.15.0

Trying to do build of app here:

https://github.com/learn-anything/electron-version

If git clone and cd app and pnpm run compile which runs:

electron-builder build --config .electron-builder.config.js --dir --config.asar=false

.electron-builder.config.js is config file.

It compiles

But when I try open the app from dist I see this:

I am not sure why but it seems that electron-builder is not bundling the node dependencies correctly for the build?

Thank you lots for any help.

[nikitavoloboev]

From my investigations I found this issue:

TryGhost/node-sqlite3#909

Which had this comment

trying to add https://github.com/electron/rebuild now

hopefully that fixes it

[nikitavoloboev]

It's unclear how to actually integrate rebuild package into the process.

I understand I have to somehow modify the dependency call to node-sqlite3 with rebuild but how is super unclear even after reading rebuild docs.

[Iku-turso]

This problem is likely caused by pnpm's isolated hoisting being strictly incompatible with electron-builder. This is realised in #6289 and here.

The current unfortunate kludge seems to be to throw all that pnpm goodness out of the window, and use something like pnpm install --shamefully-hoist.

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

[github-actions]

This issue was closed because it has been stalled for 30 days with no activity.

[AiHaibara]

for electron-builder 25 or 25.0.4
when i using pnpm and
shamefully-hoist=true in npmrc
sometimes the builded exe, it will show the error cannot find module 'jsonfile/utils'...
but using node-linker=hoisted in npmrc is ok
and in 24.13.3 shamefully-hoist=true is working.

[hifron]

I would expect something like post:install script, plugin or addon to build process. Maybe in pnpm or electron which not copy but maybe some additional work if required and not fully expose all the shit.

there even could be option when building with exposing variables which setup this option or tell pnpm to post:install situation is required without manual intervention due electron build.

Seem as pnpm(and its store) uses modified esbuild