Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Windows build fails on invalid CSC_LINK file when custom sign exe is provided #8731

Closed
rathboma opened this issue Dec 8, 2024 · 1 comment

Comments

@rathboma
Copy link

rathboma commented Dec 8, 2024

Given this windows configuration:

  win: {
    icon: './public/icons/png/512x512.png',
    target: ['nsis', 'portable'],
    publish: ['github'],
    sign: "./build/win/sign.js",
  },

and a CSC_LINK for MacOS of: ~/mac-certificate.p12, the build will fail with ⨯ Env WIN_CSC_LINK is not correct, cannot resolve: C:\Users\runneradmin\mac-certificate.p12 doesn't exist

Even though signing will take place using sign.js.

Example of this occuring:
https://github.com/beekeeper-studio/beekeeper-studio/actions/runs/12224806820/job/34099608086#step:23:132

rathboma added a commit to beekeeper-studio/beekeeper-studio that referenced this issue Dec 8, 2024
@mmaietta
Copy link
Collaborator

I took a look at the code logic. I don't think this is a bug; other than that, the error message is just incorrect.

Looks like there is a property you can set for each platform-specific config (albeit lacking jsdoc): https://www.electron.build/app-builder-lib.interface.platformspecificbuildoptions#csclink

@mmaietta mmaietta closed this as not planned Won't fix, can't repro, duplicate, stale Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants