fix: correctly log makeappx.exe errors
#21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzhao
force-pushed
the
fix/stdout-errors
branch
from
6e7956b to
72f2269
Compare
erickzhao
changed the title
MakeAppx errorsmakeappx.exe errors
bitdisaster
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the erroring e2e tests in #17, you can observe that the stderr output from MakeAppx.exe is empty:
https://github.com/electron-userland/electron-windows-msix/actions/runs/19087183080/job/54529945541?pr=17
Testing locally, it seems like the error output comes from stdout anyways. This PR fixes the issue and correctly logs error output.