Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patience & Tolerance values hard-coded to 3 and 1e-3 respectively #24

Open
rajatg-sidefx opened this issue Oct 28, 2022 · 1 comment · May be fixed by #30
Open

Patience & Tolerance values hard-coded to 3 and 1e-3 respectively #24

rajatg-sidefx opened this issue Oct 28, 2022 · 1 comment · May be fixed by #30

Comments

@rajatg-sidefx
Copy link

rajatg-sidefx commented Oct 28, 2022 •
edited
Loading

In class MyDemBones of mainCmd.cpp, the member variables tolerance and patience are initialized to (1e-3) and (3).

However, these values are never updated to those passed in via the command line.

It looks like the following lines must be added to the main function to ensure that the user-provided arguments are being respected:

model.tolerance = tolerance.getValue();
model.patience = patience.getValue();
@zigguratvertigo
Copy link
Contributor

Thanks for noticing. Got PR?

@rajatg-sidefx rajatg-sidefx linked a pull request Jan 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update model with user-provided tolerance and patience values sideeffects/dem-bones
2 participants
@zigguratvertigo @rajatg-sidefx