Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing icons for Element X. #316

Open
bmarty opened this issue May 17, 2024 · 1 comment
Open

Add missing icons for Element X. #316

bmarty opened this issue May 17, 2024 · 1 comment

Comments

@bmarty
Copy link
Member

bmarty commented May 17, 2024

Context

Element X Android still relies on a few icons provided by the Material library. I want to remove this dependency and rely only on icons from the Compound library.

Here is the list of Icons used on Element X Android which do not exist on Compound, with a preview on how they render currently:

  • Fingerprint
image
  • Backspace (for the pin composer)
image
  • Folder
  • SubdirectoryArrowLeft
image
  • Icons as header for the emoji picker:
    • EmojiEvents
    • EmojiFlags
    • EmojiFoodBeverage
    • EmojiNature
    • EmojiObjects
    • EmojiPeople
    • EmojiSymbols
    • EmojiTransportation

There are used in the header here:

image

We could also decide to use Emoji for this header. Also note that this screen on iOS does not render exactly the same. Please let me know your decision.

Also, please confirm that this icon replacement is OK, else please also provide an new icon (Google: AddAPhoto, Compound: TakePhoto):

image

Figma document

Screenshot

@pixlwave
Copy link
Member

pixlwave commented Nov 25, 2024

GraphicEq is now available as audio in v2.1.1 of the tokens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants