Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Add/edit/delete a link using the RTE in EX #1975

Closed
2 tasks done
Tracked by #1940
jonnyandrew opened this issue Aug 8, 2023 · 4 comments
Closed
2 tasks done
Tracked by #1940

[Story] Add/edit/delete a link using the RTE in EX #1975

jonnyandrew opened this issue Aug 8, 2023 · 4 comments
Assignees
Labels
A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor App: ElementX Android App: ElementX iOS T-User Story Team: Element X Feature X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA

Comments

@jonnyandrew
Copy link

jonnyandrew commented Aug 8, 2023

Description

As a user

  • I want to add a link to text in the rich text editor
  • so that I can send messages containing links

As a user

  • I want to edit or delete a link within the rich text editor
  • so that I can change or fix links in my own messages

Design

  • TBC

Size estimate

M

Dependencies

Acceptance criteria

  • User can add a link to selected text in the rich text editor.
  • User can edit a link in the rich text editor.
  • User can delete a link in the rich text editor.

Out of scope

Nothing

Android

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

iOS

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

Subtasks

Android

iOS

No tasks being tracked yet.

Library

  1. Android
@callumu
Copy link

callumu commented Oct 12, 2023

When editing a link on Android, only the link can be edited, not the word that's had the link added to it. This is different to iOS. @jonnyandrew I feel like we discussed this as an Android limitation, but can you confirm?

@jonnyandrew
Copy link
Author

Yes this is a known limitation but my understanding was that it affected all platforms as it is not yet implemented in the rust model (see open issues matrix-org/matrix-rich-text-editor#616, matrix-org/matrix-rich-text-editor#617, matrix-org/matrix-rich-text-editor#618). Are you sure it's working correctly on iOS @callumu? If so, perhaps iOS is using a workaround to achieve the behaviour @alfogrillo?

@callumu
Copy link

callumu commented Oct 12, 2023

Yes this is a known limitation but my understanding was that it affected all platforms as it is not yet implemented in the rust model (see open issues matrix-org/matrix-rich-text-editor#616, matrix-org/matrix-rich-text-editor#617, matrix-org/matrix-rich-text-editor#618). Are you sure it's working correctly on iOS @callumu? If so, perhaps iOS is using a workaround to achieve the behaviour @alfogrillo?

Oh sorry this is my fault, it doesn't exist on iOS also. Ignore my initial comment and I'll mark this as done

@jonnyandrew
Copy link
Author

No problem! Thanks for reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor App: ElementX Android App: ElementX iOS T-User Story Team: Element X Feature X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA
Projects
None yet
Development

No branches or pull requests

5 participants