Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Receiving requests to join #2579

Open
2 of 3 tasks
mxandreas opened this issue Oct 16, 2024 · 1 comment
Open
2 of 3 tasks

[Story] Receiving requests to join #2579

mxandreas opened this issue Oct 16, 2024 · 1 comment

Comments

@mxandreas
Copy link

mxandreas commented Oct 16, 2024

Description

Notifications:

  • As an admin who is managing access requests to a room
  • I want to be notified when somebody requests access
  • So that I am aware that somebody is waiting & they could get a response to their request ASAP

Browsing:

  • As an admin who is managing access requests to a room
  • I want to be able to browse all the pending requests
  • So that I can ensure that no request is missed because I was away or there were a higher number of requests

Conditions:

  • The admin here is a user with either invite, kick and/or ban permissions on the room.
  • Only the admin should see the requests (including the green dot notification in room list)
    • However, the room is not expected to be bumped to the top when the request lands.
  • The section for the pending requests (or generally the ability to accept / decline) should be available for admins only if the room’s join rule is knock or knock_restricted.

Designs

Acceptance criteria

  • Only users with invite or kick or ban permissions get notified about new requests and can browse existing ones.
  • The ability to see existing requests remains available only as long as the room's join rule is knock or knock_restricted

Size estimate

None

Dependencies

  • None

Out of scope

  • Nothing

Open questions

Questions

Preview Give feedback
No tasks being tracked yet.

Subtasks

Android

Preview Give feedback
  1. T-Task
    ganfra

iOS

Preview Give feedback
  1. T-Task
    Velin92

Rust

Preview Give feedback

Other

Preview Give feedback
No tasks being tracked yet.
@mxandreas mxandreas changed the title [Story] Receiving the requests to join [Story] Receiving requests to join Oct 16, 2024
@mxandreas
Copy link
Author

mxandreas commented Oct 29, 2024

Based on the discussion I updated the description so that the room is not expected to be bumped to the top of the room list (for the admins) when a new knock on the room arrives. This is left as a stretch goal for the following reasons:

  • It is already intentionally not the case for receiving invites for the purpose of not suffering from spamming.
  • It is also not trivial to implement this; likely requires server side changes to get a reliable/sustainable implementation.

cc @gaelledel @ganfra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant