Cannot log out (stuck on key backup dialog)

[kittykat]

Steps to reproduce

A preliminary step may be to start a new DM conversation with someone new.

1. Start logging out of an account
2. See the dialog warning me "You'll lose access to your encrypted messages"
3. Click the right button to "Connect this session to Key Backup" (I'm not sure what that actually means)
4. See spinner and then same dialog again
5. Click "Connect this session to Key Backup"
6. See "Keys restored" dialog (confusing as I was backing up keys, not restoring them)
7. Click "OK"
8. Dialog closes but I'm still logged in

Outcome

What did you expect?

To be logged out

What happened instead?

I can't log out unless I press a scary button saying that I will lose my keys

URL for webapp

staging.element.io

Application version

Element version: 1.9.3
Olm version: 3.2.3

Will you send logs?

Yes

[dbkr]

Seems it's got itself into a state where key backup isn't active, then it finds a key backup on the server, restores it to connect to it (hence asking for the password) but then doesn't go back to logging out after backing up.

[richvdh]

A preliminary step may be to start a new DM conversation with someone new.

... or just to send an encrypted message.

Note that to reproduce this it is also necessary to start from a session that is not already connected to key backup.

1. Start logging out of an account
2. See the dialog warning me "You'll lose access to your encrypted messages"
3. Click the right button to "Connect this session to Key Backup" (I'm not sure what that actually means)
4. See spinner and then same dialog again

When I get to this point, I instead see this dialog:

... followed by "Backup could not be decrypted with this Security Key: please verify that you entered the correct Security Key."

... which I think is due to #23929.

6. See "Keys restored" dialog (confusing as I was backing up keys, not restoring them)

... so I never get to this stage.

Anyway we probably need to revisit this once #23929 is fixed.

[richvdh]

I don't think this is Major, because a second attempt to log out (or clicking through the "I don't want my keys" dialog) works just fine.

[richvdh]

also, it should only affect users who did not create a security phrase (and hence connect to key backup on login), which should be (I hope) a minority.