Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky playwright test: Spotlight > should find unknown people #26138

Closed
richvdh opened this issue Sep 8, 2023 · 10 comments · Fixed by matrix-org/matrix-react-sdk#11590
Closed

Flaky playwright test: Spotlight > should find unknown people #26138

richvdh opened this issue Sep 8, 2023 · 10 comments · Fixed by matrix-org/matrix-react-sdk#11590
Labels
A-Developer-Experience T-Defect Z-Flaky-Test A test is raising false alarms

Comments

@richvdh
Copy link
Member

richvdh commented Sep 8, 2023 •
edited
Loading 

Timed out retrying after 10000ms: Expected to find element: .mx_SpotlightDialog_section.mx_SpotlightDialog_results .mx_SpotlightDialog_option, but never found it.

https://github.com/matrix-org/matrix-react-sdk/actions/runs/6115896270/job/16600238039#step:8:20244
@richvdh richvdh added T-Defect A-Developer-Experience Z-Flaky-Test A test is raising false alarms labels Sep 8, 2023
@andybalaam andybalaam mentioned this issue Sep 8, 2023
Merged
andybalaam added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 8, 2023
@andybalaam
Add waits in Spotlight Cypress tests, hoping this unflakes them
878f94b 
Attempt to fix:

* element-hq/element-web#26053
* element-hq/element-web#26140
* element-hq/element-web#26139
* element-hq/element-web#26138
@andybalaam andybalaam mentioned this issue Sep 8, 2023
Merged
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 8, 2023
@andybalaam
Add waits in Spotlight Cypress tests, hoping this unflakes them (#11590)
f1f8c6b 
Attempt to fix:

* element-hq/element-web#26053
* element-hq/element-web#26140
* element-hq/element-web#26139
* element-hq/element-web#26138
@richvdh richvdh reopened this Sep 20, 2023
@richvdh
Copy link
Member Author

richvdh commented Sep 20, 2023

https://cloud.cypress.io/projects/ppvnzg/runs/19256/test-results/dd4050c3-96e7-48fa-8ae2-b7fe7377f23b

@weeman1337 weeman1337 self-assigned this Sep 28, 2023
@weeman1337
Copy link
Contributor

My current hypothesis is that the rooms are created too quickly before the profile information is populated in Synapse. matrix-org/synapse#1444 I have found some notes bout that the user search only returns profiles of users in public rooms. But this is all a guess and I need to look into it further.

@weeman1337
Copy link
Contributor

Element Web seems to send the correct requests and also handles responses correctly. If test failures are too painful in CI we can deactivate the test until the issue is solved.

@richvdh
Copy link
Member Author

richvdh commented Sep 29, 2023

... it's certainly true that the public user directory is populated asynchronously within synapse. If the cypress tests aren't taking account of that, it could well explain the problem

@weeman1337 weeman1337 mentioned this issue Oct 12, 2023
Merged
3 tasks
@weeman1337
Copy link
Contributor

Filed a Synapse issue

@weeman1337 weeman1337 changed the title Flaky cypress test: Spotlight > should find unknown people [Disabled] Flaky cypress test: Spotlight > should find unknown people Oct 19, 2023
@DMRobertson DMRobertson mentioned this issue Oct 25, 2023
Open
@weeman1337 weeman1337 removed their assignment Dec 4, 2023
@matrixbot matrixbot mentioned this issue Dec 22, 2023
Open
@richvdh
Copy link
Member Author

richvdh commented Feb 29, 2024

cypress is dead, long live playwright

@richvdh richvdh closed this as completed Feb 29, 2024
@richvdh
Copy link
Member Author

richvdh commented Feb 29, 2024

... except this is still disabled

@richvdh richvdh reopened this Feb 29, 2024
@richvdh richvdh changed the title [Disabled] Flaky cypress test: Spotlight > should find unknown people [Disabled] Flaky playwright test: Spotlight > should find unknown people Feb 29, 2024
@github-actions github-actions bot added the Stale label Apr 24, 2024
@github-actions GitHub Actions
Copy link

This flaky test issue has not been updated in 14 days. It is being closed as presumed resolved.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2024
@richvdh richvdh reopened this Apr 24, 2024
@github-actions github-actions bot added the Stale label May 17, 2024
@github-actions GitHub Actions
Copy link

This flaky test issue has not been updated in 14 days. It is being closed as presumed resolved.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
@MidhunSureshR MidhunSureshR added the Z-Flaky-Test-Disabled The flaking test has been disabled label Jun 19, 2024
@MidhunSureshR MidhunSureshR reopened this Jun 19, 2024
@langleyd langleyd mentioned this issue Oct 18, 2024
Merged
@langleyd langleyd removed the Z-Flaky-Test-Disabled The flaking test has been disabled label Oct 23, 2024
@richvdh richvdh changed the title [Disabled] Flaky playwright test: Spotlight > should find unknown people Flaky playwright test: Spotlight > should find unknown people Oct 24, 2024
@t3chguy
Copy link
Member

t3chguy commented Oct 31, 2024

Closing as fixed

@t3chguy t3chguy closed this as completed Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Developer-Experience T-Defect Z-Flaky-Test A test is raising false alarms
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add waits in Spotlight Cypress tests, hoping this unflakes them matrix-org/matrix-react-sdk
6 participants
@richvdh @t3chguy @langleyd @weeman1337 @MidhunSureshR @RiotRobot