Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky jest test: TimelinePanel › with overlayTimeline › renders merged timeline #26500

Closed
richvdh opened this issue Nov 3, 2023 · 1 comment · Fixed by matrix-org/matrix-js-sdk#3853
Closed

Flaky jest test: TimelinePanel › with overlayTimeline › renders merged timeline #26500

richvdh opened this issue Nov 3, 2023 · 1 comment · Fixed by matrix-org/matrix-js-sdk#3853
Labels
Z-Flaky-Test A test is raising false alarms

Comments

@richvdh
Copy link
Member

richvdh commented Nov 3, 2023

https://github.com/matrix-org/matrix-js-sdk/actions/runs/6732711041/job/18299925606#step:7:8343

https://github.com/matrix-org/matrix-js-sdk/actions/runs/6745021292/job/18336042946#step:7:8344

   ● TimelinePanel › with overlayTimeline › renders merged timeline

    expect(received).toEqual(expected) // deep equality

    - Expected  - 1
    + Received  + 1

      Array [
        "roomId_event_0",
    -   "roomId_event_1",
        "virtualCallEvent1",
    +   "roomId_event_1",
      ]
@richvdh richvdh added the Z-Flaky-Test A test is raising false alarms label Nov 3, 2023
@richvdh
Copy link
Member Author

richvdh commented Nov 3, 2023

Apparently caused by matrix-org/matrix-js-sdk#3839

@richvdh richvdh changed the title Flaky jest test: TimelinePanel › with overlayTimeline › renders merged timeline Broken jest test: TimelinePanel › with overlayTimeline › renders merged timeline Nov 3, 2023
@richvdh richvdh changed the title Broken jest test: TimelinePanel › with overlayTimeline › renders merged timeline Flaky jest test: TimelinePanel › with overlayTimeline › renders merged timeline Nov 3, 2023
@richvdh richvdh mentioned this issue Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Z-Flaky-Test A test is raising false alarms
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Age fallback using origin_server_ts instead of 0" matrix-org/matrix-js-sdk
1 participant
@richvdh