Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to last RR has vanished #27883

Closed
ara4n opened this issue Aug 1, 2024 · 6 comments · Fixed by matrix-org/matrix-react-sdk#12863
Closed

Jump to last RR has vanished #27883

ara4n opened this issue Aug 1, 2024 · 6 comments · Fixed by matrix-org/matrix-react-sdk#12863
Assignees
Labels
A-Read-Receipts O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Aug 1, 2024

Steps to reproduce

  1. open MemberInfo for a user
  2. look for the "jump to last read msg" button
  3. it no longer exists

Outcome

What did you expect?

It's useful to be able to know when a user was last seen reading msgs in a room

What happened instead?

We no longer can.

Operating system

No response

Application version

Element Nightly version: 2024073101 Crypto version: Rust SDK 0.7.1 (c8c9d15), Vodozemac 0.6.0

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No

@ara4n ara4n added the T-Defect label Aug 1, 2024
@dosubot dosubot bot added A-Read-Receipts O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist labels Aug 1, 2024
@t3chguy
Copy link
Member

t3chguy commented Aug 1, 2024

Sounds like the user you're looking at simply has RRs turned off, as the option is still there otherwise.

image

@ara4n
Copy link
Member Author

ara4n commented Aug 1, 2024

huh, okay, it does seem to be that. perhaps we should grey it out rather than hide it when that happens, in order to avoid this confusion?

@americanrefugee
Copy link

Sure, we can just show a disabled version of the button (no rollover, icon and text "Disabled" colors)

@t3chguy
Copy link
Member

t3chguy commented Aug 5, 2024

@americanrefugee should there be a tooltip? if so what should it say

@americanrefugee
Copy link

"This feature is disabled"

@t3chguy
Copy link
Member

t3chguy commented Aug 5, 2024

@americanrefugee thanks for confirming, though as it happens Compound's tooltips don't seem compatible with disabled MenuItems atm so first cut will skip the tooltip

element-hq/compound#325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Read-Receipts O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
3 participants