Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Your key storage is out of sync - Forgot recovery key? - After click silently disappears #29118

Open
rda0 opened this issue Jan 28, 2025 · 6 comments · May be fixed by #29138
Open

Your key storage is out of sync - Forgot recovery key? - After click silently disappears #29118

rda0 opened this issue Jan 28, 2025 · 6 comments · May be fixed by #29138
Labels
A-E2EE O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@rda0
Copy link
Contributor

rda0 commented Jan 28, 2025

Steps to reproduce

  1. Upgrade to v1.11.91
  2. Click: Forgot recovery key?
  3. The toast silently disappears

Outcome

What did you expect?

Enter security passphrase?

What happened instead?

The toast silently disappears

Operating system

Windows 10

Application version

D-PHYS Element version: 1.11.91 Crypto version: Rust SDK 0.8.0 (21f7cc7), Vodozemac 0.8.1

How did you install the app?

https://packages.element.io/desktop/install/win32/x64/index.html

Homeserver

phys.ethz.ch

Will you send logs?

Yes

@rda0 rda0 added the T-Defect label Jan 28, 2025
@dosubot dosubot bot added A-E2EE O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jan 28, 2025
@t3chguy
Copy link
Member

t3chguy commented Jan 28, 2025

@dbkr looking at the PR code, that is what the code indeed does, but that does seem unexpected

@rda0
Copy link
Contributor Author

rda0 commented Jan 28, 2025

Maybe it has to do with that I downgraded to v1.11.90 immediately after the upgrade to inspect my Security & Privacy settings.

Enter recovery key worked!

I now have: Master private key: | cached locally (which was missing before)

Feel free to close this, I just wanted to send you logs.

@vranki
Copy link

vranki commented Jan 29, 2025

Happened to me also, and according to reports in various rooms it's not uncommon. I'd boost the priority up. This will freak non-technical users and even they are confused on what's happening.

@bertvandepoel
Copy link

I came to talk about this issue in the Element matrix room and found myself surrounded by other people who had the same issue. I would argue I'm quite technical and even I got confused. Ended up "fixing" it by resetting my backup (couldn't find the recovery key right away and I assumed a new backup would just make the syncing work again), though that has left me with having to restore a backup on new/reset clients, so yeah this is causing issues for technical users too.

I would agree that this priority should be up, as it's clearly not uncommon.

@dbkr
Copy link
Member

dbkr commented Jan 29, 2025

Oops: yes, the other toasts powered by this code have a 'dismiss' button and I... uh... forgot to make this one not a 'dismiss' button. For the record, this is telling you that one or more of your cross signing secrets are not cached locally, which they are supposed to be. The 'forgot recovery key' is just a shortcut to reset, so you can work round this for now by just getting to the reset flow via the 'enter recovery key' button.

We're also aware of some cases where verifying against other devices doesn't make this toast disappear, which seems to be because those other devices don't have the cross signing private keys cached either, and therefore can't send them over as part of verification, but this is separate.

@bertvandepoel
Copy link

Yes, I seem to be that latter case. I'm bring a device to the pre-FOSDEM matrix/element meetup on Friday at HSBXL which I'm verifying against and getting the issue that there seem to be keys not getting transferred or are missing.

Great to hear that the dismiss is a mistake though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
5 participants