Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No capitalisation when typing a new message or after a period (.) #1408

Closed
davidegirardi opened this issue Sep 22, 2023 · 5 comments
Closed
Assignees
Labels
A-Composer A-Rich-Text-Editor O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Blocked Z-Labs A defect in a feature that is behind a labs flag. Z-Polish

Comments

@davidegirardi
Copy link

Steps to reproduce

  1. Type a message
  2. Optionally type a period (.) and then continue typing

Outcome

What did you expect?

The first letter of the sentence to be upper case.

What happened instead?

The letter is lower case.

Your phone model

Samsung A53

Operating system version

Android 13

Application version and app store

0.2.3-nightly (40002030)

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

No

@davidegirardi davidegirardi added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Sep 22, 2023
@julioromano julioromano added A-Composer S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Sep 22, 2023
@bmarty
Copy link
Member

bmarty commented Sep 27, 2023

This has been fixed in #988, but when the Rich Text Editor has been integrated, we have this regression. Not sure we can fix in the EXA code. I think it has to be fixed in https://github.com/matrix-org/matrix-rich-text-editor.

@jonnyandrew WDYT?

@jonnyandrew
Copy link
Contributor

Correct, this will need a change in the library - thanks for raising matrix-org/matrix-rich-text-editor#826

@fbruetting
Copy link

This also happens when RTE is set to being off. If it’s due to RTE, why doesn’t this resolve the issue?

@kittykat kittykat added the Z-Labs A defect in a feature that is behind a labs flag. label Nov 16, 2023
@jmartinesp
Copy link
Member

This was fixed in matrix-org/matrix-rich-text-editor#826, but we still need to release a new version of the library and integrate it in the app.

This also happens when RTE is set to being off. If it’s due to RTE, why doesn’t this resolve the issue?

This wasn't a problem with the RTE itself, but with the UI component used in the library, which lacked the default flags to allow auto capitalisation.

@jmartinesp jmartinesp self-assigned this Nov 20, 2023
@frebib
Copy link
Contributor

frebib commented Nov 29, 2023

Seems to be fixed as of the latest nightlies (THANK YOU!!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer A-Rich-Text-Editor O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Blocked Z-Labs A defect in a feature that is behind a labs flag. Z-Polish
Projects
None yet
Development

No branches or pull requests

8 participants