[Shields] Shields disappearing when a session is removed

[jmartinesp]

Steps to reproduce

1. Log into a new session, don't verify it.
2. Send a message, it appears with the red shield.
3. Verify it.
4. Send a message, it appears with no shield.
5. Log out of the session.
6. In the other side, both messages don't have a shield.

Outcome

What did you expect?

According to @BillCarsonFr , both messages should have red shields since the session is no longer valid at the time of decryption.

What happened instead?

Sometimes they flicker in the timeline between 1 having a red shield and the other not having one, and none of them having the shields. Most of the time they don't have shields at all.

Your phone model

No response

Operating system version

No response

Application version and app store

EX 0.5.3-nightly (40005030)

Homeserver

element.io

Will you send logs?

Yes

Are you willing to provide a PR?

Yes

[BillCarsonFr]

Since the 5th August - we create and store SenderData when the session is created ( #3543), and we calculate the VerificationState using it (#3782)

And since this change matrix-org/matrix-rust-sdk#3751 the sender data (authenticity of the key) is updated.

So the observed behavior is now expected, and is a very good improvement compared to how it used to be!