Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention pills fall back to plain text in markdown mode #1999

Closed
Jaffex opened this issue Nov 1, 2023 · 2 comments
Closed

Mention pills fall back to plain text in markdown mode #1999

Jaffex opened this issue Nov 1, 2023 · 2 comments
Assignees
@langleyd
Labels
A-Rich-Text-Editor O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Team: Element X Feature Z-Labs A defect in a feature that is behind a labs flag.

Comments

@Jaffex
Copy link

Jaffex commented Nov 1, 2023

Steps to reproduce

Disable the Rich-Text-Editor in the settings.

Go to a chat room and mention another user by beginning to type "@" and their username.

Select the user to mention from the appearing dropdown.

The message composer will now contain a mention pill and you can compose the rest of your message. Hit send.

Outcome

What did you expect?

The mention pill to be visible and interactive in the timeline after sending the message, regardless of which style of message composer I use

What happened instead?

Your message in the timeline will show up as plain text, and is not interactive as a mention pill usually is.

Additional information

With the Rich-Text-Editor enabled, the same procedure will result in a working interactive mention pill in the timeline.

Your phone model

iPhone 12 mini

Operating system version

iOS 17.1

Application version

1.4.0

Homeserver

Synapse

Will you send logs?

No
@Jaffex Jaffex added the T-Defect label Nov 1, 2023
@pixlwave pixlwave added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely A-Rich-Text-Editor labels Nov 2, 2023
@kittykat kittykat added Team: Element X Feature Z-Schedule Z-Labs A defect in a feature that is behind a labs flag. labels Nov 15, 2023
@langleyd langleyd self-assigned this Nov 21, 2023
@langleyd langleyd mentioned this issue Nov 22, 2023
Closed
@manuroe
Copy link
Member

manuroe commented Dec 22, 2023

@Velin92 can we close this issue thanks to #2246?

@Velin92
Copy link
Member

Velin92 commented Jan 12, 2024

More than a fix we have prevented the user suggestions to appear entirely when in plain text mode since pills are only supported in RTE as of right now. We have this tracked in the RTE repo:
matrix-org/matrix-rich-text-editor#708

@Velin92 Velin92 closed this as completed Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@langleyd langleyd

Labels
A-Rich-Text-Editor O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Team: Element X Feature Z-Labs A defect in a feature that is behind a labs flag.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always send formatted content element-hq/element-x-ios
6 participants
@kittykat @pixlwave @langleyd @manuroe @Jaffex @Velin92