Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSS: misordered messages in room timeline #3132

Open
ara4n opened this issue Aug 7, 2024 · 7 comments
Open

SSS: misordered messages in room timeline #3132

ara4n opened this issue Aug 7, 2024 · 7 comments
Labels
A-Room-List A-SSS Regression or bug observed when using Simplified Sliding Sync O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue

Comments

@ara4n
Copy link
Member

ara4n commented Aug 7, 2024

Steps to reproduce

  1. Opened room
  2. Saw completely misordered timeline. It's as if the most recent msg in the room cache got stuck between newer messages and paginated messages. See rageshake for details.
  3. This is the 3rd time i've seen a variation of this today (i.e. "wrong room history")

Outcome

What did you expect?

Reliable room history.

What happened instead?

Misordered (or missing) history, which later fixes itself.

Your phone model

No response

Operating system version

No response

Application version

669

Homeserver

No response

Will you send logs?

Yes

@ara4n ara4n added the T-Defect label Aug 7, 2024
@ara4n
Copy link
Member Author

ara4n commented Aug 7, 2024

Erik's analysis was:

From what I can tell from jaeger SSS sent down the last message, and then it called /messages and got the rest of the events down in a sane order
I don't see anything abnormal going on in terms of ordering or timestamps for those events
I believe that the misordered message in the screenshot was received via SSS yesterday
Which all looks fine server side, so my guess is its some weird client side ordering of the timeline bug?

@Hywan
Copy link
Member

Hywan commented Aug 8, 2024

Nothing has changed on the Rust SDK since 2 or 3 weeks, so it looks suspicious.

Could it be related to element-hq/synapse#17510?

@ara4n
Copy link
Member Author

ara4n commented Aug 8, 2024

the fact that the timeline doesn't even show date markers for the misordered events is suspicious in terms of there also being a timeline crate bug here too though...

@Velin92 Velin92 added X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue A-Room-List S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-SSS Regression or bug observed when using Simplified Sliding Sync labels Aug 12, 2024
@ara4n
Copy link
Member Author

ara4n commented Aug 24, 2024

just had this very badly in build 686. have provided a detailed rageshake. am not sure this is really minor, as it feels very flakey for msgs to disappear and misorder when on slower data

@ara4n ara4n added S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed S-Minor Impairs non-critical functionality or suitable workarounds exist labels Aug 24, 2024
@Hywan
Copy link
Member

Hywan commented Aug 26, 2024

As long as we don't have proper room subscriptions, I feel it's a bit useless to dig into this :-/. How often does it happen on your side?

@ara4n
Copy link
Member Author

ara4n commented Aug 30, 2024

just had this again on 691.

it feels like a variation on #1279

don't think this has anything to do with sss or subscriptions tbh

filed as #3214 given this happened on send, not on open

@manuroe
Copy link
Member

manuroe commented Sep 3, 2024

it may be related to #3220. @ara4n can you still see this issue happening?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-List A-SSS Regression or bug observed when using Simplified Sliding Sync O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue
Projects
None yet
Development

No branches or pull requests

4 participants