Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room topics not visible with SSS #3312

Closed
marwing opened this issue Sep 22, 2024 · 4 comments
Closed

Room topics not visible with SSS #3312

marwing opened this issue Sep 22, 2024 · 4 comments
Labels
A-Room-Detail O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue

Comments

@marwing
Copy link

marwing commented Sep 22, 2024

Steps to reproduce

  1. Force quit the app
  2. reopen
  3. open room info for room with topic
  4. search for the topic

Outcome

Expected (iPhone, SS) Actual (iPad, SSS)
2024-09-22 02 51 52 2024-09-22 02 51 47

Some rooms have their topic displayed, but I haven't found a pattern yet.

Your phone model

iPad Pro (11-inch) (2nd gen)

Operating system version

iPadOS 18.0

Application version

1.8.3 (126)

Homeserver

Synapse 1.115.0

Will you send logs?

Yes
@pixlwave pixlwave added X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely A-Room-Detail labels Sep 26, 2024
@stefanceriu
Copy link
Member

I believe this is caused by element-hq/synapse#17698

@stefanceriu
Copy link
Member

i.e. the initial required state https://github.com/matrix-org/matrix-rust-sdk/blob/main/crates/matrix-sdk-ui/src/room_list_service/mod.rs#L148 is different than the subscription one https://github.com/element-hq/element-x-ios/blob/develop/ElementX/Sources/Services/Client/ClientProxyProtocol.swift#L43

@spaetz spaetz mentioned this issue Sep 27, 2024
Closed
@marwing
Copy link
Author

marwing commented Oct 23, 2024

This seems to be fixed after updating to 1.9.2. I suspect this is because of #3437 / matrix-org/matrix-rust-sdk#4159. element-hq/synapse#17698 has a fix in 1.118.0rc1 (which I am not running yet).
Should this issue be closed or wait for the synapse fix in a stable release?

@stefanceriu
Copy link
Member

Right, yes, the sdk change moved it to the initial required state so it's fetched as soon as setting up the lists. The synapse fix is just the cherry on top. Thanks for following up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Room-Detail O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stefanceriu @pixlwave @marwing