Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On small screens (iPhone SE), you can't cancel edits in rooms with pinned msgs #3411

Closed
ara4n opened this issue Oct 15, 2024 · 1 comment · Fixed by #3441
Closed

On small screens (iPhone SE), you can't cancel edits in rooms with pinned msgs #3411

ara4n opened this issue Oct 15, 2024 · 1 comment · Fixed by #3441
Labels
A-Composer A-Room O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Oct 15, 2024

Steps to reproduce

sm says:

EXI devs: on a small screen (iPhone SE), when editing a long message, the pinned messages banner overlays the X button, so you can’t cancel the edit (only accept it)

Outcome

What did you expect?

UI should still work on small screens.

Perhaps "if editing or replying to message, hide pinned msgs" would do it?

What happened instead?

UI became unusable due to small screen.

Your phone model

iPhone SE of some kind

Operating system version

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@ara4n ara4n added the T-Defect label Oct 15, 2024
@pixlwave
Copy link
Member

Screenshot of this happening:

Image

@pixlwave pixlwave added A-Composer S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely A-Room labels Oct 23, 2024
@pixlwave pixlwave mentioned this issue Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Composer A-Room O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a bug where the pinned items banner could overlay the composer. element-hq/element-x-ios
2 participants
@ara4n @pixlwave