Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: remove dead space from captioned images #3436

Open
wrjlewis opened this issue Oct 22, 2024 · 2 comments
Open

Request: remove dead space from captioned images #3436

wrjlewis opened this issue Oct 22, 2024 · 2 comments
Labels
A-Media O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect

Comments

@wrjlewis
Copy link

Screenshot 2024-10-22 at 12 33 45

Is your feature request related to a problem? Please describe.
With captioned image support landing in EX iOS soon (in the dev builds currently), I've noticed there is a lot of grey empty space in the message bubble when the image is tall and thin with a caption.

Describe the solution you'd like
I believe this is solved in other messengers by cropping the image so that it fits squarely in the bubble, but at the expense of cutting off the bottom of the image in the thumbnail.

  • I think this is the best trade off personally. Since it removes the empty grey bubble space and keeps the design as compelling and awesome as it was before image captions.

For example, the same captioned image appears in WA like this:
Screenshot 2024-10-22 at 12 43 52

@manuroe
Copy link
Member

manuroe commented Oct 23, 2024

thanks @wrjlewis . This is very good point. We probably some logic about to handle such aspect ratios: a min image width with crop to fit and wrapping the text to input.
We also need to manage very weird aspect ration like 10px x 1000px.
cc @amshakal @pixlwave @bmarty

@pixlwave
Copy link
Member

pixlwave commented Oct 23, 2024

Seems worth adding that this is larger than media captions as we also have the case of replies/threads where the same happens.

Additionally, there's the edge case of small images to handle as we (generally) don't upscale images:

screenshot@2x

@pixlwave pixlwave added A-Media T-Defect S-Tolerable Low/no impact on users O-Occasional Affects or can be seen by some users regularly or most users rarely labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Media O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants