Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly show Recovery Key and Encryption Reset screens from the home screen banner. #3482

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Directly show Recovery Key and Encryption Reset screens from the home screen banner. #3482

merged 1 commit into from
Nov 4, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Nov 4, 2024 •
edited
Loading

Final part of the reworking the flows for #3388, this PR adds the secondary button and directly presents the required screens directly instead of presenting them inside of the Settings screen.

There may still be a tiny bit of work to do around the success/failure states when confirming the recovery key.

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-04.at.16.03.15.mp4

@pixlwave pixlwave added the pr-change for updates to an existing feature label Nov 4, 2024
@pixlwave pixlwave requested a review from a team as a code owner November 4, 2024 15:57
@pixlwave pixlwave requested review from Velin92 and removed request for a team November 4, 2024 15:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against f538411

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 4, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
848 1 847 0
View the top 1 failed tests by shortest run time 
PreviewTests test_emojiPickerScreen()
Stack Traces | 1.64s run time 
failed - Snapshot "Screen" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_emojiPickerScreen-iPhone-16-en-GB.Screen.png"
@+
"file:.../tmp/PreviewTests/test_emojiPickerScreen-iPhone-16-en-GB.Screen.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8803711 is less than required 1.0
The lowest perceptual color precision 0.0 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@pixlwave pixlwave merged commit 6190a03 into develop Nov 4, 2024
9 checks passed
@pixlwave pixlwave deleted the doug/key-storage-secondary-button branch November 4, 2024 17:21
@pixlwave pixlwave mentioned this pull request Nov 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Velin92 Velin92 Velin92 approved these changes

Assignees
No one assigned
Labels
pr-change for updates to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixlwave @Velin92