-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The GitHub Pages (developer docs) CI workflow is failing on develop #16804
Comments
Do we actually ever use the generated documentation? |
I'm not actually sure where it is hosted, if anywhere. |
Let's just burn it then? We can always resurrect it if we have a need for it. |
cc @reivilibre who originally wrote it and should have a say here I think. |
Unfortunately, this did cause the v1.99.0 documentation to fail to build during the release: https://github.com/element-hq/synapse/actions/runs/7542746086. Presumably we can just merge the fix to the |
I have found the developer docs: https://element-hq.github.io/synapse/dev-docs/develop/ They're pretty sparse at the moment, holding just a description of the federation sender. It also seems that they haven't built correctly since v1.95: https://github.com/element-hq/synapse/tree/gh-pages/dev-docs I'll see whether I can fix the error, otherwise will opt for dropping it for now. |
I'm not sure what would have changed here to break it, probably a dep bump. I would like to keep it if possible, it'd be nice to start having more developer documentation. I have a couple of WIP bits I'd like to finish up and add someday as well. |
If we can easily fix this then I'm happy for us to do that, but I don't think we should either burn time on this or leave it broken. |
It is broken, and we only seemed to have been building it for the federation sender. Closes #16804
Failing workflow: https://github.com/element-hq/synapse/actions/runs/7475715177/job/20344447295
Not sure why this would be failing now unless a version bump occurred recently.
The text was updated successfully, but these errors were encountered: