Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silently drop invites determined to be spam #17492

Open
H-Shay opened this issue Jul 26, 2024 · 0 comments
Open

Silently drop invites determined to be spam #17492

H-Shay opened this issue Jul 26, 2024 · 0 comments

Comments

@H-Shay
Copy link
Contributor

H-Shay commented Jul 26, 2024

Following on from matrix-org/mjolnir#300, rejecting spam invites can just precipitate more abuse, as it can alert attackers that their names have been added to a ban list. This could be addressed by silently dropping spam invites, rather than rejecting them with an error. For example if the spam check here
https://github.com/element-hq/synapse/blob/568051c0f07393b786b9d813a1db53dd332c9fc2/synapse/handlers/room_member.py#L900-914 determines that the invite is spam, return early with a 200 rather than raising an 403 error.
This could either be implemented as-is or could be a config option to give people the ability to choose to silently ignore spam invites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant