Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate freezing unauth media endpoints and enabling auth media into two separate settings #17639

Closed
BurnyBoi opened this issue Aug 30, 2024 · 2 comments

Comments

@BurnyBoi
Copy link

BurnyBoi commented Aug 30, 2024

Description:

Currently there is one setting that when enabled both requires authentication on the new media endpoints, AND freezes media on the legacy unauthenticated endpoints. My plan was to enable auth media, and then implement nginx rules to lock down the unauthed endpoint to a small subset of users, but with both of these actions on the same setting I can't do this.

Requesting that authenticated media is split into two separate config options: One for requiring auth on the new endpoints, and another for freezing the old endpoints.

@tulir
Copy link
Contributor

tulir commented Sep 1, 2024

The new endpoints are always enabled and always require auth, there's no option to not require auth nor to disable them.

enable_authenticated_media simply prevents new media from being accessible over old endpoints, as the docs say:

When set to true, all subsequent media uploads will be marked as authenticated, and will not be available over legacy unauthenticated media endpoints

@BurnyBoi
Copy link
Author

BurnyBoi commented Sep 3, 2024

Nice, so I can accomplish what I'm thinking then by just leaving the config option as false. Thanks!

@BurnyBoi BurnyBoi closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants