Skip to content

Conversation

@anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Nov 7, 2025

This PR better documents how we configure cibuildwheel, and changes a couple things. The functional changes here:

Otherwise:

  • We don't build at all for i686 anyways, so -musllinux_1686 could be replaced by *i686* with no functional effect.

This PR is based on release-1.142, and I've marked it as a release blocker to stop Python 3.9 wheels from being built for the final 1.142.0 release (which claims that Python 3.9 is no longer supported).

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

The functional changes here:

- Moving `cp39-*` to `skip` stops us from building wheels for Python 3.9, which was incorrectly done in #19119 (that PR only stopped the tests from failing in CI, but we were still building [and shipping] cpython 3.9 wheels).
- Likewise moving `cp3??t-*` builds here prevent them from being created at all. #19140 only prevented testing them.

Otherwise:

- We don't build at all for i686 anyways, so `-musllinux_1686` could be replaced by `*i686*
@anoadragon453 anoadragon453 marked this pull request as ready for review November 7, 2025 14:45
@anoadragon453 anoadragon453 requested a review from a team as a code owner November 7, 2025 14:45
Comment on lines +405 to +406
# - cp38: Python 3.8 is end-of-life.
# - cp39: Python 3.9 is end-of-life.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will no longer be required after cibuildwheel recognises our minimum defined python version in #19137.

@anoadragon453 anoadragon453 merged commit 39f8e28 into release-v1.142 Nov 10, 2025
41 of 43 checks passed
@anoadragon453 anoadragon453 deleted the anoa/update_cibuildwheel_config branch November 10, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants