Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime errors occur when importing Glyph or FormIconField components #220

Open
acampbellb opened this issue Dec 28, 2017 · 0 comments
Open

Comments

@acampbellb
Copy link

This issue appears to be due to a change to export within Octicons.js. Previously, the export was as follows..

module.exports = {
list: list,
keys: pluck(list, 'value'),
map: map
};

It has since been changed to..

export const Octicon = {
list: list,
keys: pluck(list, 'value'),
map: map
};

Therefore, changes are required in the Glyph.js and FormIconField.js source files to accommodate the extra object level that was introduced (Octicon).

  1. Elemental\components\FormIconField.js

from:
const ICON_MAP = require('../Octicons').map;
const ICON_KEYS = require('../Octicons').keys;
to:
const ICON_MAP = require('../Octicons').Octicon.map;
const ICON_KEYS = require('../Octicons').Octicon.keys;

  1. Elemental\components\Glyph.js

from:
const icons = require('../Octicons').map;
const validNames = require('../Octicons').keys;
to:
const icons = require('../Octicons').Octicon.map;
const validNames = require('../Octicons').Octicon.keys;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant