Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 7.1.0 #1304

Merged
merged 11 commits into from
Aug 1, 2023
Merged

Release 7.1.0 #1304

merged 11 commits into from
Aug 1, 2023

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Apr 6, 2023

@jeremypw jeremypw mentioned this pull request Apr 6, 2023
@jeremypw
Copy link
Collaborator Author

jeremypw commented Jun 4, 2023

I'd like #1309 to be merged before release so there is consistent use of dialogs not infobar.

@jeremypw
Copy link
Collaborator Author

jeremypw commented Jun 4, 2023

It would be nice if #1320 could be merged too as this is a really annoying issue.

@jeremypw jeremypw added the Status: Blocked Something else needs to be done before this can be fixed label Jul 14, 2023
@jeremypw
Copy link
Collaborator Author

Just noticed a new regression which needs looking into before release.

@jeremypw jeremypw requested review from zeebok and removed request for zeebok July 23, 2023 17:21
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release tag date is a bit old at this point but I think this is ready for review/approval unless you want a little testing done for the full release

@jeremypw
Copy link
Collaborator Author

@zeebok Yes, I wanted to do a few days testing before updating the release date and marking ready for review. Probably be ready beginning of next week. Need to update the metainfo too.

@jeremypw jeremypw marked this pull request as ready for review July 31, 2023 14:57
@jeremypw jeremypw removed the Status: Blocked Something else needs to be done before this can be fixed label Jul 31, 2023
@zeebok
Copy link
Contributor

zeebok commented Jul 31, 2023

Should you include the issues in that top checklist in the metainfo?

@jeremypw
Copy link
Collaborator Author

jeremypw commented Aug 1, 2023

@zeebok I only include fixes for issues that were present in the last released version of Code or that have some significance to the user (like new/changed features/appearance). Things like correcting problems with a recent unreleased commit or code cleanups are not included. I think the regressions were all caused by unreleased commits so I did not include them. If I have missed something that changed something in the last released version please let me know.

@zeebok zeebok merged commit 488bfd2 into master Aug 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants