Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct sidebar item is focused, or none, when tab removed #1320

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

jeremypw
Copy link
Collaborator

Fixes #1319

This fixes the issue by ensuring that a document that is not open in the document viewer is not selected in the sidebar so that it always activates and opens when clicked.

It also ensures the sidebar selects the current document when a tab is closed.

@jeremypw jeremypw marked this pull request as ready for review May 21, 2023 18:39
@jeremypw jeremypw mentioned this pull request Jun 4, 2023
10 tasks
@jeremypw jeremypw added the Priority: Medium Should be addressed when time allows label Jul 6, 2023
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! I keep forgetting this was thing and am glad to see it fixed

@zeebok zeebok merged commit 26cdb9e into master Jul 24, 2023
6 checks passed
@zeebok zeebok deleted the unselect-removed branch July 24, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Should be addressed when time allows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document does not open when clicked if already focused
2 participants