Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw spaces on current line option #1348

Merged
merged 7 commits into from
Feb 18, 2024
Merged

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jul 7, 2023

Fixes #570

Adds a third draw-space mode as requested. In this mode spaces are always drawn on the current line. They are also drawn on any selections. To allow the user to choose between three states, a switch is replaces by a combobox.

Screenshot from 2024-02-11 18 32 33

@jeremypw jeremypw added the Needs Design Waiting for input from the UX team label Aug 2, 2023
@jeremypw jeremypw requested a review from a team February 11, 2024 18:35
@zeebok
Copy link
Contributor

zeebok commented Feb 16, 2024

I am noticing that if I have whitespace at the end of a line, it will still draw the spaces when on Current and on a different line:
image

@jeremypw
Copy link
Collaborator Author

@zeebok Looks like the same thing happens in master. If it can be fixed here without significantly increasing the diff I will.

@jeremypw
Copy link
Collaborator Author

@zeebok: Looks like this is deliberate behaviour (when draw spaces is ON at all) - see #433

@jeremypw jeremypw merged commit 1359d09 into master Feb 18, 2024
6 checks passed
@jeremypw jeremypw deleted the draw-spaces-on-current-line-option branch February 18, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Waiting for input from the UX team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draw Spaces On Current Line
2 participants