Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronise and save symbol outline width. #1389

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Synchronise and save symbol outline width. #1389

merged 2 commits into from
Dec 20, 2023

Conversation

jeremypw
Copy link
Collaborator

Fixes #1329

  • Add a new saved-state key outline-width
  • Bind to corresponding property of DocumentView
  • Keep Documents, DocumentView and saved-state settings in sync

A consequence of the PR having a single setting is that the outline pane width is always the same in all documents rather than individually adjustable but this is unlikely to be an issue.

@jeremypw jeremypw requested a review from a team December 15, 2023 16:59
colinkiama
colinkiama approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@colinkiama colinkiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Awesome!

@colinkiama colinkiama merged commit 742b31f into master Dec 20, 2023
6 checks passed
@colinkiama colinkiama deleted the symbol-pane-width-setting branch December 20, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinkiama colinkiama colinkiama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Symbol pane changes size after reopening code
2 participants
@jeremypw @colinkiama