Reliably open documents from sidebar #1465
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1403
Using the
item-selectedsignal from the SourceList to open documents causes problems when documents are removed for any reason because this causes unwanted documents to selected and opened. Inmasterthis is fixed by a hack involving some select signals being ignored but this is not reliable. Quite often clicking on an item in the sidebar fails to open it because the signal is falsely ignored.Instead, this PR uses item activation to trigger document opening/tab selection. To maintain the same single click behaviour the SourceList is modified so
activate_on_single_clickis accessible.