Skip to content
This repository has been archived by the owner on May 28, 2023. It is now read-only.

Require "provides" in AppStream data #709

Open
cassidyjames opened this issue Jan 27, 2019 · 8 comments
Open

Require "provides" in AppStream data #709

cassidyjames opened this issue Jan 27, 2019 · 8 comments

Comments

@cassidyjames
Copy link
Contributor

It looks like this might be preventing https://github.com/bartzaalberg/recipes/ from showing up in AppCenter?

@cassidyjames
Copy link
Contributor Author

It looks like this (probably?) isn't why it's not showing up; other apps also lack it and show up fine. Regardless, if it's best practice, we should still at least warn on its absence.

https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-provides

@unbelievableflavour
Copy link

I can confirm it's not the issue in Recipes. Provides tag has been added and released but it's still not shown in AppCenter.

@btkostner
Copy link
Contributor

@unbelievableflavour
Copy link

unbelievableflavour commented Mar 4, 2019

Sorry, guys I think I found the error. Until now i didn't notice the .svg error in the link @btkostner send. I checked the files locally and they are also broken here so it's my problem. I will create a new icon and repush the app. That should probably fix it. When it works I will close this issue.

It's still is weird though that Houston build succeeds, there should probably be a check for that.

@btkostner
Copy link
Contributor

@bartzaalberg Houston just checks if the file exists. It does no svg or xml parsing to ensure the file is an image, valid, or even if it has data.

@unbelievableflavour
Copy link

unbelievableflavour commented Mar 4, 2019

Ah ok. Well I added a new icon. Let's hope this fixes things.

@unbelievableflavour
Copy link

This fixed my issue. Should the ticket stay open or can it be closed?

@btkostner
Copy link
Contributor

@bartzaalberg Keep it open. It's useful to have this as a test in houston.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants