Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup source recipe on Launchpad #394

Open
ryonakano opened this issue Oct 13, 2024 · 6 comments
Open

Setup source recipe on Launchpad #394

ryonakano opened this issue Oct 13, 2024 · 6 comments
Assignees

Comments

@ryonakano
Copy link
Contributor

Problem

We haven't provided Monitor in our PPA yet.

Proposal

Setup a source recipe on Launchpad and make it possible to install Monitor through our PPA.

Note that we need to change the package name of Monitor from com.github.stsdc.monitor to io.elementary.monitor (#393) before working on this.

Prior Art (Optional)

No response

@danirabbit danirabbit self-assigned this Oct 14, 2024
@danirabbit danirabbit added this to OS 9 Oct 14, 2024
@danirabbit danirabbit moved this to Todo in OS 9 Oct 14, 2024
@danirabbit
Copy link
Member

Import has been set up here: https://code.launchpad.net/~elementary-apps/elementaryos/+git/monitor

And a daily recipe here: https://code.launchpad.net/~elementary-os/+recipe/monitor-daily

But I'm not building it daily yet because there's a debian folder in tree in addition to a deb-packaging branch

@danirabbit danirabbit moved this from Todo to In progress in OS 9 Oct 14, 2024
@danirabbit
Copy link
Member

@stsdc
Copy link
Member

stsdc commented Oct 15, 2024

../meson.build:20:17: ERROR: Subproject exists but has no meson.build file.
Not sure why it says that but most frequent issue is missing: git clone --recursive

@ryonakano
Copy link
Contributor Author

Maybe we either:

Either way we need to setup a git mirror and recipe of live-chart on Launchpad...

@stsdc
Copy link
Member

stsdc commented Oct 16, 2024

Do you think it will make sense to fork live-chart, so we can make changes to it when necessary? Since it is a core component of Monitor 🤔

@ryonakano
Copy link
Contributor Author

I'm not a big fan of forking personally and prefer contributing to the upstream instead, but agree to do so if the upstream is no longer actively maintained and needs some fixes to use it in our code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

No branches or pull requests

3 participants