Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Metadata Discoverer to AudioObject? #693

Open
danirabbit opened this issue Jan 21, 2022 · 0 comments · May be fixed by #697
Open

Move Metadata Discoverer to AudioObject? #693

danirabbit opened this issue Jan 21, 2022 · 0 comments · May be fixed by #697

Comments

@danirabbit
Copy link
Member

Currently the metadata discoverer runs when adding files to the queue, which is fine for this design, but if there are future views, we probably want metadata even for audio objects that aren't queued.

Now that metadata discovery isn't attached to the playbin bus, we can probably move this to AudioObject so that it runs whenever an audio object is created. This would make all metadata storage pretty self contained there and keep the playback manager scoped to only handling playback and not also metadata

@danirabbit danirabbit moved this to To Discuss in Music 7 Jan 21, 2022
@danirabbit danirabbit linked a pull request Jan 21, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Discuss
Development

Successfully merging a pull request may close this issue.

1 participant