Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose current dark/light mode over gsettings #84

Open
danirabbit opened this issue Aug 31, 2023 · 4 comments
Open

Expose current dark/light mode over gsettings #84

danirabbit opened this issue Aug 31, 2023 · 4 comments
Labels
Needs Design Waiting for input from the UX team Status: Confirmed Verified by someone other than the reporter

Comments

@danirabbit
Copy link
Member

Problem

Currently to get/set the current color scheme we have to create a whole DBusProxy and talk to accounts service and it's all very messy and ugly.

Proposal

It would be nice to have the current dark/light/nopreference exposed over gsettings so that we can get/set this without having to do a whole bunch of extra work

Prior Art (Optional)

See: https://github.com/elementary/quick-settings/blob/833718813cd3d346aecc99de635122a5896de115/src/PopoverWidget.vala#L36

@danirabbit danirabbit added the Needs Design Waiting for input from the UX team label Aug 31, 2023
@lenemter lenemter added the Status: Confirmed Verified by someone other than the reporter label Sep 1, 2023
@lenemter
Copy link
Member

lenemter commented Sep 1, 2023

I think it would be better if you could do this using Granite rather than gsettings.

@danirabbit
Copy link
Member Author

@lenemter I don't think granite is really an appropriate place since it's an application library and this is only useful for desktop components

@Marukesu
Copy link
Contributor

Marukesu commented Sep 5, 2023

i think something akin to a libaccounts-pantheon is better, a gsetting will only be a extra place to keep things in sync and then we would need to deal with issues like the users's home/config directory being locked, or not readable/modifiable, etc...

@danirabbit
Copy link
Member Author

I don't think any library is a solution to this problem. There are only two places that these are set-able: system settings and the panel.

Right now most of the related settings are exposed over gsettings but the dark/light setting itself is over dbus so there's a mix of gsettings and dbus required just to set light mode or dark mode.

It could be that it would be better to remove the existing gsettings and do everything over dbus, but right now there is a mix of both and it's messy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Waiting for input from the UX team Status: Confirmed Verified by someone other than the reporter
Projects
None yet
Development

No branches or pull requests

3 participants