Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation at file download stage #47

Open
andrazrepar opened this issue Apr 26, 2022 · 5 comments
Open

Validation at file download stage #47

andrazrepar opened this issue Apr 26, 2022 · 5 comments
Assignees

Comments

@andrazrepar
Copy link
Collaborator

If the user selects the option Without namespaces, then we need to package the information about validation in a txt file and provide a download link. Which means that after the transformation is complete, in addition to the file download link, we also need to have a link for the validation log file.

This is the output of the mapper.Transform function:

[2022-04-26 11:46:51,064] [INFO] Calling relaxNg.validate.
[2022-04-26 11:46:51,065] [INFO] Relax-NG validation failed:
<string>:1:0:ERROR:RELAXNGV:RELAXNG_ERR_NOELEM: Expecting an element sense, got nothing
<string>:1:0:ERROR:RELAXNGV:RELAXNG_ERR_CONTENTVALID: Element body failed to validate content

@LukeItUp, can you prepare the backend function?

@LukeItUp
Copy link
Collaborator

LukeItUp commented May 15, 2022

Deployed to staging.

After making download call without namespaces, API stores validation log file and it can be pulled using the following call:
GET http://0.0.0.0:5000/api/transform/XFID/validation/DSID

@andrazrepar andrazrepar assigned gradisarjoze and unassigned LukeItUp May 23, 2022
@gradisarjoze
Copy link
Collaborator

@LukeItUp this endpoint always returns No validation file found, retry downloading file without namespaces even thought the file was downloaded with strip_ns=true.

@gradisarjoze
Copy link
Collaborator

A button was pushed to staging. It's present after you download the file without ns.

@andrazrepar
Copy link
Collaborator Author

I get 409 response when clicking the button.
image

@andrazrepar
Copy link
Collaborator Author

Also, the first download button, downloads the validation file, not the dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants