"Notify only in background" does not work

[faerot]

I have pulled latest version and just build far2l and it annoyingly shows notifications about every run command even when I am running it directly, without minimizing far2l. "Notify only in background" seems to have no effect, only when I disable notifications completely, they go away.

[unxed]

The reason is probably that far2l in tty mode does not know the state of focus on terminal window.
Possible solution is to track it using \033[?1004l mode. Focus tracking should have 3 states:

• we have focus
• we do not have focus
• focus state is unknown (some terminals do not support reporting current state)

Notifications should be sended only if we definitely do not have focus.

[unxed]

@Dazzar56 could you please help with adding this?

[spnethw]

At the moment there is just a stub here:

far2l/WinPort/src/Backend/TTY/TTYBackend.cpp

Lines 960 to 963 in 9ef3316

	bool TTYBackend::OnConsoleIsActive()
	{
	return false;//true;
	}

[elfmz]

may change to return _far2l_tty ? false : true; as quick workaround

[elfmz]

..or better: #2567

[elfmz]

check current master please if you can

[unxed]

Works for me :)

[spnethw]

Works as expected in: Konsole, Gnome Terminal, kovidgoyal's kitty.