Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required parameter "-o" not detected as missing if not present. #21

Open
kjellp opened this issue Jan 24, 2020 · 2 comments
Open

Required parameter "-o" not detected as missing if not present. #21

kjellp opened this issue Jan 24, 2020 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@kjellp
Copy link

kjellp commented Jan 24, 2020

Is the start workflow script is provided all required parameters except "-o", it will start the run without warning the user, and crash due to failing operations later on (that is not evident for the user is due to the missing "-o" paramter).

@kjellp kjellp added the bug Something isn't working label Jan 24, 2020
@kjellp kjellp added this to the Release 2 milestone Jan 24, 2020
@oskarvid
Copy link

Although you are right that there is no error saying -o is missing, I cannot reproduce the error as you are describing it. I tried running Selma with -o missing and with no argument to -o and both times it crashed immediately. See my attached screenshot for reference.
Can you take a screenshot of your command line as well as the end of the workflow execution?
selma-no-o

@oskarvid
Copy link

The error was reproduced correctly by me, and I figured out a way to fix it.
But I don't want to give in to accepting new additions to the current milestone since doing so will push the release date, this will get fixed in milestone 3. Only things related to what we have discussed in the testing document will get addressed in this release.
If it had been a critical bug that broke everything it would have been different, but the workflow works, it stops the execution correctly if no argument, or no -o flag, is given.
I know this is stringent and may seem excessive, but it's important so we don't end up adding things here and there and delaying the release for too long.

@oskarvid oskarvid modified the milestones: Release 2, Milestone 3 Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants