Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mismatch spec for Plug.Conn.Query.decode #1169

Closed
prihandi opened this issue Oct 5, 2023 · 1 comment · Fixed by #1170
Closed

Mismatch spec for Plug.Conn.Query.decode #1169

prihandi opened this issue Oct 5, 2023 · 1 comment · Fixed by #1170
Labels
Kind:Bug

Comments

@prihandi
Copy link
Contributor

prihandi commented Oct 5, 2023 •
edited
Loading

I just updated my project dependencies this morning and mix dialyzer is broken. Then, I found it's on Plug.Conn.Query.decode/1 call. After search the latest changes/release, I found that the spec for the function hasn't changed, while the default for 2nd argument(initial) changed from empty map to empty list/keyword on this commit

Will create PR for this
@prihandi prihandi mentioned this issue Oct 5, 2023
Merged
@whatyouhide
Copy link
Member

Closing in favor of #1170.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Kind:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix spec for Plug.Conn.Query.decode prihandi/plug
2 participants
@whatyouhide @prihandi