-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uncontrolled text copies in MC-Questions #21
Comments
Hi Julen, Is there any progress on this issue right now? We are experiencing the same issue. |
The previous approach had some assumptions (e.g., it assumed there was a singe instance of the editor on the same page) that lead to some bugs and corner cases. Now the plugin hooks on the form submit event and clean the highlighting <span> tags there. The cleaning doesn't use any regexes any longer. Instead it uses DOM operations that are more robust and potentially faster. Also multilang tag highlighting <span>'s are now removed/added when switching to/from HTML view, reducing clutter when editing the HTML code. Some initial coding style cleanup work has been carried out. More to follow. Tested in Firefox 56 and Chromium 61.0.3163.100. Closes eljulians#2 eljulians#18 eljulians#21
Hi @shatami, @andy-hediger I have revamped the editor plugin and fixed the issue you are having (and also issues #2 and #18). I've tried to contact Julen about it, but have been unsuccessful so far. If you want to try my modified plugin, you can get it at https://github.com/iarenaza/moodle-atto_multilang2 |
Hi Julen, given that you have already merged the changes that fix this issue, you can close it now. Best regards. |
THANK YOU Iñaki !! |
Hi Julen
We are using atto_multilang on our moodle.bfh.ch (3.2.3) THANK YOU for this functionality :)
while setting up an MC-Question in French and German, we now experience the following issue
(I send you screenshots of the situations, so that you may reproduce it):
situation1: just entered the text into question / answer1 / answer2
situation2: added multilang tags to the question-text using the menu in ATTO and saved/continued
situation3: now added multilang tags to the answer1-text again with menu in ATTO no save at this point
situation4: just saved this situation (nothing else) and now without my intention or doing so in the "Allg.Feedback"-field the same text as in answer1 is copied. that is in the field which is exactly above the one, i did actually change.
this behavior is repeated when further fields are tagged and saved, so that all fields have inserted the same tagged text from below...
regards
Andy Hediger
for_tracker.zip
The text was updated successfully, but these errors were encountered: