-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
International geocoding #9
Comments
Okay I ended up doing this way differently than expected. Namely I rely on OpenStreetMap to use the unabbreviated street names, then I go through and detect the language with lingua-rs (should use WOF official/spoken languages instead) and then do the substitutions based on that language. There are some issues. Anecdotally it seems to work ok for spanish and catalan street names but I haven't had much luck with french or german street names. |
Where did you get all those language-specific substitutions from? |
The dictionaries are from libpostal, looks like they're unattributed which is my bad. I'll fix it real quick. |
Fixed in 237fedd |
At some point I did start using WOF spoken languages for abbreviations by the way! So no more lingua-rs false classifications. These were especially common in spot checking in California where many of the streets and places have Spanish names. This led to some interesting cases where street names weren't properly abbreviated in the Airmail index and a search for these streets would yield no results or suboptimal results if the search query used their abbreviated names. |
That's great! |
It's been a while since I've put development time into this project but I suspect that it tokenizes by spaces and only applies substitutions if there's a full token match. Not ideal especially for French and German, probably others too. |
I think going parserless will get us most of the way to reasonable international performance, but we'll need to ditch
permute_road
and friends. I'm thinking it makes the most sense to use the following algorithm for that, for each POI:I think this is a reasonable way to do international permute_street but it means we'll need to perform numex at query time, because e.g. "third ave" will become 3rd ave" during indexing, and we need to match that behavior if we want to match the correct documents.
We'll need to modify the dictionary substitution behavior to add the empty string for each street_type substitution for languages where it's appropriate, otherwise "fremont ave" won't match "fremont ave n"
TODO: strasse suffixes and whatnot will need to be handled too. I might look into the libpostal codebase to see if there's anything we can reuse there.
The text was updated successfully, but these errors were encountered: