Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more flexible customisation options #9

Open
ellessenne opened this issue Dec 14, 2022 · 0 comments
Open

Add more flexible customisation options #9

ellessenne opened this issue Dec 14, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ellessenne
Copy link
Owner

Customising the plot part (with the Kaplan-Meier curves) is currently a pain, and requires adding arguments for any additional customisation option.

Maybe we could collapse everything into a single argument that is then added to the whole plot, something like:

KMunicate(fit = KM, time_scale = time_scale, .extra = ...)

...where .extra is then added to the plot (likely in here), with the following logic:

if (!is.null(.extra)) {
    plot <- plot + .extra
}

This is worth pursuing, as it would greatly simplify codebase and give the user more flexibility.

@ellessenne ellessenne added the enhancement New feature or request label Dec 14, 2022
@ellessenne ellessenne self-assigned this Dec 14, 2022
@ellessenne ellessenne added this to the 0.3.0 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant