Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumentation infrastructure for plugins #27

Open
deadtrickster opened this issue Feb 16, 2017 · 7 comments
Open

Instrumentation infrastructure for plugins #27

deadtrickster opened this issue Feb 16, 2017 · 7 comments

Comments

@deadtrickster
Copy link
Member

Add API so plugins can instrument themselves, just like main Elli does. Something generic, or just use Prometheus/Prometheus data model?

@deadtrickster deadtrickster self-assigned this Feb 16, 2017
@yurrriq
Copy link
Member

yurrriq commented Oct 17, 2017

👍 for generic, but skewing Prometheus-friendly.

@yurrriq
Copy link
Member

yurrriq commented Mar 6, 2018

Any new thoughts on this?

@yurrriq yurrriq changed the title Instrumentation infrostructure for plugins Instrumentation infrastructure for plugins Mar 6, 2018
@tsloughter
Copy link
Member

I don't understand what this means.

@yurrriq
Copy link
Member

yurrriq commented Apr 30, 2018

I think the idea is to codify and expose an API for calculating timings, as we do internally, such that a middleware can do the same to instrument itself, without having to reimplement anything... if that makes sense.

@tsloughter
Copy link
Member

Ah ok, that is how I took it at first too but not sure how that relates to prometheus? We are just talking about the timing and size atoms, like those that already exist?

@yurrriq
Copy link
Member

yurrriq commented May 5, 2018

/ping @deadtrickster

@paulo-ferraz-oliveira
Copy link
Contributor

Should we consider Open Telemetry for this? I wouldn't mind working on it, but:

  1. I need to know what timings we're interested in (all of them?)
  2. if I could come up with the scope and name for the telemetry events or if there's ideas around those already...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants