Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request data format mismatch #2

Open
galdor opened this issue Dec 23, 2018 · 1 comment
Open

Request data format mismatch #2

galdor opened this issue Dec 23, 2018 · 1 comment

Comments

@galdor
Copy link

galdor commented Dec 23, 2018

I was reading the sources of this module to learn about elli, and two things came to my attention in handle_event/3

  • The last value in the second argument should be {Timings, Sizes} instead of just Timings.
  • timer:now_diff cannot be used since values in the Timings property list are not erlang:timestamp() values (they are simple integers).

I guess elli changed some things, but elli_access_log was not updated.
@yurrriq
Copy link
Member

yurrriq commented Dec 26, 2018

I guess elli changed some things, but elli_access_log was not updated.

Sounds about right. Pull requests are most welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@galdor @yurrriq