Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix equality check of oneOf decoder #905

Closed
wants to merge 1 commit into from
Closed

Fix equality check of oneOf decoder #905

wants to merge 1 commit into from

Conversation

shuhei
Copy link

@shuhei shuhei commented Sep 2, 2017

Fixes #904

  • Renaming the existing _Json_listEquality as _Json_arrayEquality because it actually works on JavaScript arrays instead of Lists
  • Adding a new _Json_listEquality function that works on Elm Lists

@process-bot
Copy link

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@jinjor jinjor requested a review from evancz September 3, 2017 08:04
@rupertlssmith rupertlssmith mentioned this pull request Mar 4, 2022
Open
@rupertlssmith
Copy link

This is a good patch and fixes a subtle bug that people could spend hours figuring out.

This patch is old enough that in the mean time JSON stuff got moved to a separate package from core. Would you be able to open a new PR against elm/json for this?

elm/json#15

@shuhei
Copy link
Author

shuhei commented Mar 4, 2022

Hi, thanks for looking into this old PR! I'm on vacation right now and also have been out of touch with Elm for a while. If you need this fix soon, please feel free to create a PR to the elm/json repo.

@shuhei shuhei closed this Mar 4, 2022
@rupertlssmith
Copy link

If you are out of touch with Elm, then I will create the PR in elm/json - your fix applies just the same in the new package.

@rupertlssmith rupertlssmith mentioned this pull request Mar 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evancz evancz Awaiting requested review from evancz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Equality check on Json.Decode.oneOf always returns true
3 participants
@shuhei @process-bot @rupertlssmith